Check that funder covers the fee spike buffer multiple after a splice#4433
Open
tankyleo wants to merge 2 commits intolightningdevkit:mainfrom
Open
Check that funder covers the fee spike buffer multiple after a splice#4433tankyleo wants to merge 2 commits intolightningdevkit:mainfrom
tankyleo wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
tankyleo
force-pushed
the
2026-02-splice-assertions
branch
from
ed77b45 to
9035906
Compare
Notably, if a party splices funds into the channel, their new balance must be above the new reserve.
We do this for HTLCs, so we should also do this for splices. This applies to `only_static_remote_key` channels alone.
tankyleo
force-pushed
the
2026-02-splice-assertions
branch
from
9035906 to
1959d52
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4433 +/- ##
==========================================
+ Coverage 85.87% 85.90% +0.02%
==========================================
Files 157 159 +2
Lines 103769 104315 +546
Branches 103769 104315 +546
==========================================
+ Hits 89115 89613 +498
- Misses 12158 12203 +45
- Partials 2496 2499 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and